search

Magisk-Modules-Alt-Repo / submission

Information regarding the submission of Magisk Modules to the Alt-Repo.
173 stars 8 forks source link

[Module] PocketMine-MP4Android #215

Closed TukangM closed 9 months ago

TukangM commented 10 months ago

ID

pmmp

Name

PocketMine-MP4Android

Description

Run Minecraft Bedrock edition on android natively! Screenshot_20240113-234915_Termux Screenshot_20240114-093845_Termux

Module repository link

https://github.com/TukangM/PocketMine-MP4Android

Source code link (for compiled binaries/APKs)

https://github.com/pmmp/PocketMine-MP/releases

Atrate commented 10 months ago

https://github.com/TukangM/PocketMine-MP4Android/blob/b554c5ed3663e35ddb3f610f9beda7f4528bb0b5/customize.sh#L40

Not how you place things in /system/bin using magisk. Use overlays (just place it in $MODDIR/system/bin) and NEVER copy it into the system partition manually.

Made with AI generated chat.openai.com

Nice of you to provide a source, have you tested that your module works correctly?

TukangM commented 10 months ago

Nice of you to provide a source, have you tested that your module works correctly?

I have tried it on my phone with ksu. it works with the usual PocketMine-MP server Linux

Not how you place things in /system/bin using magisk. Use overlays (just place it in $MODDIR/system/bin) and NEVER copy it into the system partition manually.

Do you mean this? (I still do not understand)

#!/system/bin/sh

MODDIR=${0%/*}

I just followed the documentation provided by Magisk and I read one example of customize.sh from several modules in Magisk alt repo

and customized.sh is generated by AI and at least on my phone it functions normally

Atrate commented 10 months ago

Do you mean this? (I still do not understand)

Just remove this line

cp "$MODDIR/start-pmmp" "/system/bin"

And change

chmod +x "/system/bin/start-pmmp"

to

chmod +x "$MODDIR/system/start-pmmp"

And tell me whether it works after the modification

TukangM commented 9 months ago

done yet

Atrate commented 9 months ago

https://github.com/TukangM/PocketMine-MP4Android/blob/96e0bfdca470f21498891132af3fadc3acc4b327/customize.sh#L40

This line is still unnecessary

TukangM commented 9 months ago

oh i forgot

Atrate commented 9 months ago

Approved.

I have created a repository for you at: https://github.com/Magisk-Modules-Alt-Repo/pmmp , enjoy!

Check your e-mail inbox for an invite to your new repository and remember to 'Watch' your repository on Github to have new issues in it show up in your feed.

Make sure to change your local repository's push URLs or configure 2 parallel push URLs.

TukangM commented 9 months ago

Make sure to change your local repository's push URLs or configure 2 parallel push URLs.

@Atrate ... i barely don't know how sync automaticly from my repo 😅. i use gitpod.io to make this module image

TukangM commented 9 months ago

oh i get it thanks never mind i didn't get how that work 2 pararel push