search

Magisk-Modules-Repo / Detach

Detach
GNU General Public License v3.0
250 stars 23 forks source link

Code clean up #26

Closed sobuj53 closed 3 years ago

sobuj53 commented 3 years ago

Fixed a rare condition when detach crond schedule will not be executed. Clean up some additional code to make it compact. Added variable declaration within service.sh which were not declared. This will fix creating of sh file in sdcard

sobuj53 commented 3 years ago

There is however one error which I couldn't resolve unfortunately. That is, in service.sh file there will be a line

sh "$MAGMOD/services.sh" > "$MAGMOD/first_detach_result.txt" 2>&1 but there is no services.sh file available in detach directory image

I've searched in Detach file but there is no reference of this. Can you please take a look?

xerta555 commented 3 years ago

sh "$MAGMOD/services.sh" > "$MAGMOD/first_detach_result.txt" 2>&1 but there is no services.sh file available in detach directory

services.sh file is automaticly extracted in the module folder when you install the module through Magisk Manager.