Code fix - Githubissues

Magisk-Modules-Repo / Detach

Detach

GNU General Public License v3.0

250 stars 23 forks source link

Code fix #27

Closed sobuj53 closed 3 years ago

sobuj53 commented 3 years ago

Code has been fixed by xerta555 Rom. Moved crond schedule to post boot entry.

sobuj53 commented 3 years ago

please don't merge yet. I think it has some issue.

sobuj53 commented 3 years ago

Can you please take a look at sobuj53-test-1? What is this test repo about?

Well after you fixed the compatibility.txt file the service.sh was running in infinite loop because of sh "$MAGMOD/service.sh" > "$MAGMOD/first_detach_result.txt" 2>&1 line in the service file. As it was misspelled like services.sh that's why we didn't observe this behavior earlier.
I tried to fixed this behavior by creating a new sh file and calling it from service.sh only once.

xerta555 commented 3 years ago

@hoypolli I have check your main.sh file and I'm not necessarily against adding a new sh file in the module, but I've never had a negative feedback when the script doesn't run when the device starts 🤷🏼‍♂️

sobuj53 commented 3 years ago

I think the pull request is ready to merge. Please test and merge if you think it's okay

sobuj53 commented 3 years ago

@xerta555 can you please test Detach-test repo? I've updated sqlite3 to its latest version 3.35.5. Also added magisk sepolicy rules to work under fully selinux enforcing system. We can merge those changes if you find them ok.

sobuj53 commented 3 years ago

@xerta555 hope this will fix any surprise error. Hopefully those are my final changes

xerta555 commented 3 years ago

@xerta555 hope this will fix any surprise error. Hopefully those are my final changes

I also hope, i have in mind to test internally on Telegram the last BETA test version, then from 10 positive feedbacks, migrate all the changes of the module to make the brand new version official.