Magisk-Modules-Repo / Detach

Detach
GNU General Public License v3.0
250 stars 23 forks source link

Problem with "su -c -detach -id" #8

Closed ovizii closed 4 years ago

ovizii commented 4 years ago

edit### I am on Android 10 - could this be the issue?

I am trying to detach youtube because I want to use youtube vanced. The problem is, that every so often youtube reappears inside the Play Store with updates. I have edited detach.txt and un-commented youtube. It works for a few days at a time then reappears in the Play Store...

I opened Termius and entered this command: su -c Detach -id com.google.android.youtube

I then tried to copy/paste the result from the Termius window, sorry for the messy format, not sure how to do this better:

grep: /Detach/module.prop: No such file or directory                                                                                                                                                            ==Detach                                                                                                                                                                                                          Detach work in progress...                                                                               touch: '/Detach/instant_run.sh': No such file or directory                                               chmod: /Detach/instant_run.sh: No such file or directory                                                 /system/bin/detach[875]: /Detach/sqlite: inaccessible or not found                                       /system/bin/detach[875]: can't create /Detach/instant_run.sh: No such file or directory                  /system/bin/detach[875]: can't create /Detach/instant_run.sh: No such file or directory                  /system/bin/detach[875]: can't create /Detach/instant_run.sh: No such file or directory                  sed: /Detach/service.sh: No such file or directory                                                       /system/bin/detach[875]: can't create /Detach/instant_run.sh: No such file or directory                  touch: '/Detach/first_detach_result.txt': No such file or directory                                      chmod: /Detach/first_detach_result.txt: No such file or directory                                        /system/bin/detach[875]: can't create /Detach/first_detach_result.txt: No such file or directory         grep: /Detach/first_detach_result.txt: No such file or directory                                                                                                                                                  Done                                                                                                                                                                                                              Instant file ready to be executed, path of the file:                                                      /Detach/instant_run.sh                                                                                                                                                                                           bash-4.3

fr-og commented 4 years ago

This is due to an error at line 30 of https://github.com/Magisk-Modules-Repo/Detach/blob/master/system/bin/Detach

Change MODS_DIR=/data/adb/modules

To MAGIMG=/data/adb/modules

See https://github.com/Magisk-Modules-Repo/Detach/pull/7/commits/1cd262ef2897b856556f13b35599790d1b7a85ff

ovizii commented 4 years ago

so I assume I can just wait for the next release of your magisk module then run su -c Detach -id com.google.android.youtube again and it will work?

fr-og commented 4 years ago

It's not my module and the issue was raised over 20 days ago.

On your phone, with a root enabled file manager (e.g. solid explorer, total commander), navigate to /data/adb/modules/detach/system/bin and then edit line 30 of 'Detach' as above.

ovizii commented 4 years ago

Doesn't seem to work, getting these errors, sorry for the broken formatting was posting from my phone.

`grep: /Detach/module.prop: No such file or directory ==Detach Detach work in progress... touch: '/Detach/instant_run.sh': No such file or directory chmod: /Detach/instant_run.sh: No such file or directory /system/bin/Detach[875]: /Detach/sqlite: inaccessible or not found /system/bin/Detach[875]: can't create /Detach/instant_run.sh: No such file or directory /system/bin/Detach[875]: can't create /Detach/instant_run.sh: No such file or directory /system/bin/Detach[875]: can't create /Detach/instant_run.sh: No such file or directory sed: /Detach/service.sh: No such file or directory /system/bin/Detach[875]: can't create /Detach/instant_run.sh: No such file or directory touch: '/Detach/first_detach_result.txt': No such file or directory chmod: /Detach/first_detach_result.txt: No such file or directory /system/bin/Detach[875]: can't create /Detach/first_detach_result.txt: No such file or directory grep: /Detach/first_detach_result.txt: No such file or directory Done Instant file ready to be executed, path of the file: /Detach/instant_run.sh bash-4.3$

`

fr-og commented 4 years ago

Those are the same path errors as your OP. This indicts that you didn't make the edit correctly.

Check what you've done.

If you are unable to edit and save the file on your phone then uninstall the Magisk repo version and install this instead, which has the single-line edit in it. Detach-v3.1_20.0_FIX (1).zip

ovizii commented 4 years ago

Thanks for the help. I did edit the right file, my root file explorer even created a .bak file after the edit so I am unsure what went wrong.

Still, after uninstalling and flashing your modded version the script now executes and youtube is hidden. lets see if this permanently fixes the issue.

ovizii commented 4 years ago

Actually, let me leave this issue open so the author of the module sees it.

xerta555 commented 4 years ago

@ovizii Hi, sorry for the delay. The deployment of the news on the repository being effective, this kind of bug has been fixed with this version.

ovizii commented 4 years ago

Thanks. I just wanted to add that a day later, youtube again appeared as an available update in my play store. I assume there's no permanent fix and since I am using detach to hide a single app I will stop using detach as its too much hassle for one app.