search

Magisk-Modules-Repo / GoogleDialerFramework

GoogleDialerFramework
66 stars 17 forks source link

voicemail tab not showing #11

Open zolstarym opened 4 years ago

zolstarym commented 4 years ago

Andoid 10 Galaxy S9+

Voicemail tab doesn't seem to show, nor does a visual voicemail setting show in the voicemail settings menu. Another different phone with google dialer installed by default shows the VVM tab on the same carrier as this one, and it also has a change pin and visual voicemail toggle in the settings, so I don't think it is the carrier.

psyscope commented 4 years ago

Maybe we are missing additional Google Dialer/Visual Voice Mail apks or libraries?

On Sun, Apr 19, 2020, 7:41 PM zolstarym notifications@github.com wrote:

Andoid 10 Galaxy S9+

Voicemail tab doesn't seem to show, nor does a visual voicemail setting show in the voicemail settings menu. Another different phone with google dialer installed by default shows the VVM tab on the same carrier as this one, and it also has a change pin and visual voicemail toggle in the settings, so I don't think it is the carrier.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Magisk-Modules-Repo/GoogleDialerFramework/issues/11, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACMH7H2LUK4ZYJTZJT3PFVLRNOD3NANCNFSM4MMAB6IA .

TheJulianJES commented 4 years ago

I haven't heard of anybody getting visual voicemail to work on non-pixel devices (although this might have changed recently). Also, could you please post information about the phone and ROM you're using?

zolstarym commented 4 years ago

soldier rom based on samsung stock android

worstperson commented 3 years ago

From my experience, installing the dialer as a privileged app unlocks this feature. It's always been a pain to get it to actually work on stock roms and I've not had any success since Android 10. Works without issue in Lineage OS.

I gather related files(permissions, preferred, sysconfig, framework, overlay, and the dialer app) from the OpenGApps "stock" zip and make a magisk module to place them. I disable the original dialer with "pm disable". You can always just flash that zip in recovery if you have space.

worstperson commented 3 years ago

I place these files specific to the dialer app(I place in the product folder for my own convenience, they can all be installed in system ofc):

/system/product/etc/default-permissions/opengapps-permissions-q.xml
/system/product/etc/permissions/com.google.android.dialer.support.xml
/system/product/etc/permissions/privapp-permissions-google.xml
/system/product/etc/sysconfig/dialer_experience.xml
/system/product/framework/com.google.android.dialer.support.jar
/system/product/overlay/DefaultDialerOverlay.apk
/system/product/overlay/PhoneOverlay.apk
/system/product/overlay/TelecomOverlay.apk
/system/product/priv-app/GoogleDialer/GoogleDialer.apk

I also place these files to enable pixel device features:

/system/product/etc/sysconfig/google_build.xml
/system/product/etc/sysconfig/google_exclusives_enable.xml

I place some additional permissions and configs found in the OpenGApps installer, but don't have any reason to believe they are required. Note that GoogleDialer.apk is architecture dependent and it is also probably worth it to check for differences between Android versions if you wanted to make a generic module.