Magisk-Modules-Repo / HideNavBar

GNU General Public License v3.0
498 stars 55 forks source link

Doesn't work on Android 11 beta 3 :-( #14

Closed ekeppel closed 3 years ago

ekeppel commented 4 years ago

Beta 3 appears to now detect when gesture navigation is disabled and defaults to one of the other methods, so this module no longer seems to work.

Device: Taimen (Pixel 2 XL) Magisk Canary 20420

DanGLES3 commented 3 years ago

Disable my module and send me the original gestures overlays that are on /product/overlays

ekeppel commented 3 years ago

Sorry for the delay. Here you go:

NavigationBarModeOverlays.zip

DanGLES3 commented 3 years ago

Should be fixed on the latest update 6.7, Sorry for the delay

pbanj commented 3 years ago

i still get the 3 button nav bar. trying to use this with fluid navigation gestures and was hoping this would get rid of the 3 button nave bar. i really regret updating to 11 lol

DanGLES3 commented 3 years ago

i still get the 3 button nav bar. trying to use this with fluid navigation gestures and was hoping this would get rid of the 3 button nave bar. i really regret updating to 11 lol

Could you try uninstalling and reinstalling my module? It worked fine for another user that tried it

pbanj commented 3 years ago

let me try

pbanj commented 3 years ago

nope still there. should i be telling fng to hide the nav bar still or not?

DanGLES3 commented 3 years ago

nope still there. should i be telling fng to hide the nav bar still or not?

No, also is the gestures option still gone for you?

pbanj commented 3 years ago

the gesture options in system settings? thats there. just told it not to try and hide, reinstalled your mod and the bar is still there. im on a pixel 3a if that helps at all

https://cdn.discordapp.com/attachments/399670410565910529/754499118222671923/Screenshot_20200912-202923.png

DanGLES3 commented 3 years ago

the gesture options in system settings? thats there. just told it not to try and hide, reinstalled your mod and the bar is still there. im on a pixel 3a if that helps at all

So, did you enable the gestures?

pbanj commented 3 years ago

the gesture options in system settings? thats there. just told it not to try and hide, reinstalled your mod and the bar is still there. im on a pixel 3a if that helps at all

So, did you enable the gestures?

enabling them makes it go full screen but fluid navigation gestures doesnt work. just the stock gestures

pbanj commented 3 years ago

what im trying to use https://play.google.com/store/apps/details?id=com.fb.fluid&hl=en_US

DanGLES3 commented 3 years ago

the gesture options in system settings? thats there. just told it not to try and hide, reinstalled your mod and the bar is still there. im on a pixel 3a if that helps at all

So, did you enable the gestures?

enabling them makes it go full screen but fluid navigation gestures doesnt work. just the stock gestures

Then that's not really an issue with my module tbh, that's an fluid NG issue, iirc it isn't yet compatible with Android 11

pbanj commented 3 years ago

ya was hoping your mod would be able to hide it at least until they updated

DanGLES3 commented 3 years ago

ya was hoping your mod would be able to hide it at least until they updated

My mod was only designed to hide the gesture bar, if you want to hide the 3 button navbar then add this to your build.prop qemu.hw.mainkeys=1

DanGLES3 commented 3 years ago

Fluid can no longer hide the navbar because Google removed the overscan command on Android 11

pbanj commented 3 years ago

ya was hoping your mod would be able to hide it at least until they updated

My mod was only designed to hide the gesture bar, if you want to hide the 3 button navbar then add this to your build.prop qemu.hw.mainkeys=1

oooo ill have to give that a try

Fluid can no longer hide the navbar because Google removed the overscan command on Android 11

ya i knew that part

pbanj commented 3 years ago

qemu.hw.mainkeys=1

it worked you, i could hug you