Magisk-Modules-Repo / HideNavBar

GNU General Public License v3.0
497 stars 55 forks source link

Do not hide the navbar/back button when the keyboard is shown #2

Closed SergeyKasmy closed 4 years ago

SergeyKasmy commented 4 years ago

Without the navbar the keyboard is located way too low and it is somewhat uncomfortable to type. Is there a way to still show the navbar with the keyboard, so that the keyboard would be a bit raised? Screenshot_20191203_012732

spookymyo commented 4 years ago

I agree! It's too low.

thedupin commented 4 years ago

I personally installed the module exactly for removing totally. In this case I increase the height of the keyboard on it settings. Every keyboard has it.

But could have a 2 option while installing and all.

SergeyKasmy commented 4 years ago

The deal with increasing the height of the keyboard in the settings is that the spacebar and enter keys are still way too low and our of the comfortable typing zone, at least for me

Madis0 commented 4 years ago

For me it isn't too low, but the gestures are interfering with the keyboard, especially the assistant action.

Could the module just remove the gestures when a keyboard is shown? Keeping only the side back gesture active.

DanGLES3 commented 4 years ago

Really awesome module, thanks! The only issue I have is that without the navbar the keyboard is located too low and it is somewhat uncomfortable to type. Is there a way to still show the navbar with the keyboard, so that the keyboard would be a bit raised? Screenshot_20191203_012732

my module's sole purpose was to remove the navbar entirely, if you still want it on the keyboard you should perhaps use the immersive gestures module

DanGLES3 commented 4 years ago

I personally installed the module exactly for removing totally. In this case I increase the height of the keyboard on it settings. Every keyboard has it.

But could have a 2 option while installing and all.

i would rather not as then my module could be percieved as a copy of the immersive gestures module

DanGLES3 commented 4 years ago

For me it isn't too low, but the gestures are interfering with the keyboard, especially the assistant action.

Could the module just remove the gestures when a keyboard is shown? Keeping only the side back gesture active.

well the v3 update should have addresed the issue by slightly lowering the trigger area, i could probably make it even smaller but that might break the gestures, also i can't selectively disable gestures (that is outside my control)

Madis0 commented 4 years ago

For me it isn't too low, but the gestures are interfering with the keyboard, especially the assistant action. Could the module just remove the gestures when a keyboard is shown? Keeping only the side back gesture active.

well the v3 update should have addresed the issue by slightly lowering the trigger area, i could probably make it even smaller but that might break the gestures, also i can't selectively disable gestures (that is outside my control)

Using v6 with Fleksy and it is still bad, swiping up triggers either assistant or home (if assistant is disabled).

Wouldn't "breaking the gestures" be the same as disabling them? If yes, I would suggest trying that.

DanGLES3 commented 4 years ago

For me it isn't too low, but the gestures are interfering with the keyboard, especially the assistant action. Could the module just remove the gestures when a keyboard is shown? Keeping only the side back gesture active.

well the v3 update should have addresed the issue by slightly lowering the trigger area, i could probably make it even smaller but that might break the gestures, also i can't selectively disable gestures (that is outside my control)

Using v6 with Fleksy and it is still bad, swiping up triggers either assistant or home (if assistant is disabled).

Wouldn't "breaking the gestures" be the same as disabling them? If yes, I would suggest trying that.

by breaking i mean the gestures would completely stop working (everywhere)

Madis0 commented 4 years ago

How about showing a bar as tall as the normal built-in one when the keyboard is active? Possibly just black/colored/transparent, no white line needed.

Would solve the gesture issue and would not look the same as default/immersive gestures module.

DanGLES3 commented 4 years ago

How about showing a bar as tall as the normal built-in one when the keyboard is active? Possibly just black/colored/transparent, no white line needed.

Would solve the gesture issue and would not look the same as default/immersive gestures module.

that's beyond what i can do, i can only control the stock navbar values and the keyboard navbar and pill are both tied to the same value (navbar_frame_height)

DanGLES3 commented 4 years ago

For me it isn't too low, but the gestures are interfering with the keyboard, especially the assistant action.

Could the module just remove the gestures when a keyboard is shown? Keeping only the side back gesture active.

what's your keyboard app?, if it's gboard then there is a module that can add a small bar underneath gboard to reduce conflict with gestures

SergeyKasmy commented 4 years ago

use the immersive gestures module

The deal with that is that the gesture bar hurts readability really bad and your solution is way better in that regard.

there is a module that can add a small bar underneath gboard

What's that module called?

Madis0 commented 4 years ago

I'm using Fleksy and I forgot it already has an option for this! Settings > Advanced > Change keyboard insets > Bottom.

DanGLES3 commented 4 years ago

use the immersive gestures module

The deal with that is that the gesture bar hurts readability really bad and your solution is way better in that regard.

there is a module that can add a small bar underneath gboard

What's that module called?

navbar-space.zip

SergeyKasmy commented 4 years ago

That's exactly what I was looking for. Works great in combination with our module. Thanks a lot!