Magisk-Modules-Repo / HideNavBar

GNU General Public License v3.0
498 stars 55 forks source link

'0' key of lockscreen keypad cut off by fingerprint sensor on OnePlus Phones #4

Closed KyleGospo closed 4 years ago

KyleGospo commented 4 years ago

May need to add some padding to the bottom of the lockscreen pinpad to resolve, currently the lack of a navbar pushes it low enough that the '0' key clips with the fingerprint sensor area, making it hard to press.

DanGLES3 commented 4 years ago

i'll see what i can do but i'm not sure if i'm able to add padding to the pinpad, i'm also not sure how well this would work on other devices as it may move the pinpad way too close to the clock

DanGLES3 commented 4 years ago

Also, don't Oneplus devices already have the option to hide the navbar?

KyleGospo commented 4 years ago

Also, don't Oneplus devices already have the option to hide the navbar?

Yes, although with a very different gesture setup. Your solution works much better.

DanGLES3 commented 4 years ago

Also, don't Oneplus devices already have the option to hide the navbar?

Yes, although with a very different gesture setup. Your solution works much better.

i'll see what i can do, i may need to include a special overlay just for Oneplus devices, could you kindly send me the systemui.apk from your device?

KyleGospo commented 4 years ago

Here you are, and thanks again! https://drive.google.com/file/d/133zglT89pNcaFf-HzTdnsXO0OUDl8OpG/view?usp=sharing

DanGLES3 commented 4 years ago

Here you are, and thanks again! https://drive.google.com/file/d/133zglT89pNcaFf-HzTdnsXO0OUDl8OpG/view?usp=sharing

DanGLES3 commented 4 years ago

Here you are, and thanks again! https://drive.google.com/file/d/133zglT89pNcaFf-HzTdnsXO0OUDl8OpG/view?usp=sharing

test-signed2.zip

try this

KyleGospo commented 4 years ago

No change on my phone, same spacing.

DanGLES3 commented 4 years ago

i'll have to put this issue on hold, the padding is controlled by a layout value so it makes it extremely difficult for me to modify it using an overlay, once i figure something out i'll be sure to post here