Magisk-Modules-Repo / HideNavBar

GNU General Public License v3.0
494 stars 55 forks source link

Hide little close keyboard button #59

Closed Vendicated closed 2 years ago

Vendicated commented 2 years ago

I got very annoyed by the space below the keyboard and this module fixed it, thanks a lot for that (working flawlessly on Oneplus 8t OxygenOs 11), but now the close keyboard button is right below my comma button so I keep pressing it accidently. it would be awesome if this module could hide the button completely, it is obsolete anyway since you can just use the back gesture to close it

DanGLES3 commented 2 years ago

Unfortunately I've yet been unable to find a way to remove it as it seem to be made entirely in code with no resources I can edit to hide them

I'll try taking another look but can't promise anything

Vendicated commented 2 years ago

thats a bummer :( Thanks anyway for the effort (and also for the fast reply ๐Ÿ˜ฎ)

DanGLES3 commented 2 years ago

thats a bummer :( Thanks anyway for the effort (and also for the fast reply ๐Ÿ˜ฎ)

Well I've got good news for ya, I've found a way, give me awhile and I'll send ya a version

DanGLES3 commented 2 years ago

thats a bummer :( Thanks anyway for the effort (and also for the fast reply ๐Ÿ˜ฎ)

https://drive.google.com/file/d/1BZBBPW_CS1VYBwDOny8qYeVM_zZMnEMj/view?usp=drivesdk

Try this

Vendicated commented 2 years ago

Doesn't remove it for me sadly. Do I have to choose a specific option?

I selected

DanGLES3 commented 2 years ago

Doesn't remove it for me sadly. Do I have to choose a specific option?

I selected

  • immersive
  • hide pull yes
  • reduce size yes
  • sensitivity high
  • disable back no

Mind showing me the module folder in data/adb/modules/hidenavbar/system/product/overlay?

Vendicated commented 2 years ago

Screenshot_20210915-033502

Vendicated commented 2 years ago

still doesn't work Screenshot_20210915-034752

DanGLES3 commented 2 years ago

Doesn't remove it for me sadly. Do I have to choose a specific option?

I selected

  • immersive
  • hide pull yes
  • reduce size yes
  • sensitivity high
  • disable back no

I've had goofed up, here it is

https://drive.google.com/file/d/1BvWwfYnf1Hjx6sLZqgGVX93kM3hYyIPA/view?usp=drivesdk

DanGLES3 commented 2 years ago

Doesn't remove it for me sadly. Do I have to choose a specific option?

I selected

  • immersive
  • hide pull yes
  • reduce size yes
  • sensitivity high
  • disable back no

Try the new one I've just sent, I've messed up the old overlay, it was conflicting with the pill hide one

Vendicated commented 2 years ago

Not working still

DanGLES3 commented 2 years ago

Not working still

Run the following command on a root terminal and show me the results under systemui

cmd overlay list

Idk why it's so hard making systemui overlays

I'll have to try making them on my PC soon

DanGLES3 commented 2 years ago

Not working still

Don't give up yet, I just need to make an overlay that works

If you wish to try this later or tomorrow if you don't have the time that's fair enough

I'll get on my PC soon

Vendicated commented 2 years ago

sorry I misclicked lol https://gist.github.com/Vendicated/80fbcd2e06e2edfbdf1be4d9b74c3399

DanGLES3 commented 2 years ago

Not working still

For now you can try this hacked up Substratum theme I've just made

https://drive.google.com/file/d/1BwhEMCv0oDDIdCCU3ReHjsTcIg_30lZg/view?usp=drivesdk

Select 0dp in the theme selection, install, reboot and apply

I'd recommend Substratum lite

Vendicated commented 2 years ago

ยป [com.android.systemui]: ERROR: resource directory '/data/user/0/projekt.substratum/cache/SubstratumBuilder//res/' does not exist
ยป [com.android.systemui]: Installation of "com.android.systemui" has failed.```
Vendicated commented 2 years ago

ah it works on lite. and now it really is gone ๐Ÿ‘€ thanks a lot you are awesome :)

DanGLES3 commented 2 years ago

ah it works on lite. and now it really is gone ๐Ÿ‘€ thanks a lot you are awesome :)

Great, I'm on my PC now, I'll see if I can make a functional overlay that I can put in my module

DanGLES3 commented 2 years ago

ah it works on lite. and now it really is gone thanks a lot you are awesome :)

https://drive.google.com/file/d/1dGkTjsoPFvxpUYFJ-iMqHcS2SrYBthLz/view?usp=sharing

This should work, i've messed up my previous overlays, disable the substratum overlay before trying

Apologies for making you test so much stuff

Vendicated commented 2 years ago

yep, it's working now! and don't worry I don't mind

DanGLES3 commented 2 years ago

yep, it's working now! and don't worry I don't mind

just making sure, u disabled the substratum overlay prior to installing the module and rebooting correct? (just want to make sure there were no substratum remnants in memory or anything of the sort)

If it's all good i shall make this an option during installation on my module

Vendicated commented 2 years ago

yes, the substratum theme is no longer applied

DanGLES3 commented 2 years ago

yes, the substratum theme is no longer applied

Great, thanks a lot for helping me on testing this

DanGLES3 commented 2 years ago

yes, the substratum theme is no longer applied

https://drive.google.com/file/d/14xedvz0KOYC8ZTXon3zACFfbjSiGjNJc/view?usp=sharing

Here's the module with that as an separate option if you wish to test it out for me

DanGLES3 commented 2 years ago

yes, the substratum theme is no longer applied

the update is already up if you wish to test it

Vendicated commented 2 years ago

sorry I didn't see this until now. works wonderfully thank you very much!!