search

Magisk-Modules-Repo / HideNavBar

GNU General Public License v3.0
494 stars 55 forks source link

White bar in immersive hide pill mode #79

Closed jfitzroy74 closed 2 years ago

jfitzroy74 commented 2 years ago

Great work on fixing the gcam lag, although I now have an odd looking white bar/space at the bottom of my screen in immersive hidden pill mode. This was never the case with previous versions. Do you think it is something you could look at please? Pixel 6 Pro, Android 12, March update. Thanks in advance

DanGLES3 commented 2 years ago

Great work on fixing the gcam lag, although I now have an odd looking white bar/space at the bottom of my screen in immersive hidden pill mode. This was never the case with previous versions. Do you think it is something you could look at please? Pixel 6 Pro, Android 12, March update. Thanks in advance

Mind providing an screenshot? The Gcam lag fix required setting the navbar to be 1.0dp (lower values didn't seem to fix the issue) in height instead of 0dp, it was mostly invisible during my testing, fixing this would likely involve undoing the lag fix

jfitzroy74 commented 2 years ago

Great work on fixing the gcam lag, although I now have an odd looking white bar/space at the bottom of my screen in immersive hidden pill mode. This was never the case with previous versions. Do you think it is something you could look at please? Pixel 6 Pro, Android 12, March update. Thanks in advance

Mind providing an screenshot? The Gcam lag fix required setting the navbar to be 1.0dp (lower values didn't seem to fix the issue) in height instead of 0dp, it was mostly invisible during my testing, fixing this would likely involve undoing the lag fix

Yes of course I'll attach an example. Sorry of it seems I'm being very picky. I would be happy to go back to v11 of it's possible for me to do so? The image attached shows a white line space at the bottom of dark backgrounds. WhatsApp is also very noticeable. I love this module and have been using it for a long time. It's pretty much the main reason I root to get rid of the hideous large dead space around the stock nav bar. Thank you in advance Screenshot_20220323-183141

jfitzroy74 commented 2 years ago

This is what it looks like in WhatsApp Screenshot_20220323-183859

DanGLES3 commented 2 years ago

Great work on fixing the gcam lag, although I now have an odd looking white bar/space at the bottom of my screen in immersive hidden pill mode. This was never the case with previous versions. Do you think it is something you could look at please? Pixel 6 Pro, Android 12, March update. Thanks in advance

Mind providing an screenshot? The Gcam lag fix required setting the navbar to be 1.0dp (lower values didn't seem to fix the issue) in height instead of 0dp, it was mostly invisible during my testing, fixing this would likely involve undoing the lag fix

Yes of course I'll attach an example. Sorry of it seems I'm being very picky. I would be happy to go back to v11 of it's possible for me to do so? The image attached shows a white line space at the bottom of dark backgrounds. WhatsApp is also very noticeable. I love this module and have been using it for a long time. It's pretty much the main reason I root to get rid of the hideous large dead space around the stock nav bar. Thank you in advance Screenshot_20220323-183141

It seems it's definitely the Gcam fix, you may roll back to v11 for the time being, i plan on making the Gcam fix optional on v13, unfortunately there is no perfect fix for this other than hope Google fixes whatever wonkyness goes on with Gcam

And don't worry, you're not being picky, i didn't like this fix for the lag either but it's the only one that I could find

jfitzroy74 commented 2 years ago

Would you be kind enough to provide a download link for v11 please? I can't find one anywhere and I no longer have a local copy. Thanks again for your speedy replies. Great module!

DanGLES3 commented 2 years ago

Would you be kind enough to provide a download link for v11 please? I can't find one anywhere and I no longer have a local copy. Thanks again for your speedy replies. Great module!

Immersive-Gestures-(QS)v11.0(38).zip

Here ya go

jfitzroy74 commented 2 years ago

Thank you very much for all your help and all your great work with this module. I've installed v11 and back to my preferred state. Cheers

DanGLES3 commented 2 years ago

Just a reminder that version 13 was released which includes total control over the module parameters, so I'll be closing this issue now, have a good day/night

Thank you very much for all your help and all your great work with this module. I've installed v11 and back to my preferred state. Cheers

jfitzroy74 commented 2 years ago

Thank you for the reminder. I have installed v13 and everything is perfect. Excellent work!

Regards,

Jason

On Mon, 4 Apr 2022 at 7:09, @.***> wrote:

Just a reminder that version 13 was released which includes total control over the module parameters, so I'll be closing this issue now, have a good day/night

Thank you very much for all your help and all your great work with this module. I've installed v11 and back to my preferred state. Cheers

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>