Magisk-Modules-Repo / HideNavBar

GNU General Public License v3.0
498 stars 55 forks source link

Can the gesture height be even lower ? #8

Closed EricwanAR closed 4 years ago

EricwanAR commented 4 years ago

The module is great, but gesture is too sensitive. Every time I move the pushing button at the bottom of the screen (when using Snapseed for example)it would trigger the app switch gesture. I modded the module myself by changing the gesture height from 23dp to 18dp and it works perfect for me. I wonder if you can make the value as default

DanGLES3 commented 4 years ago

I will consider, i need to do some tests to see if lowering this much doesn't create any issues

hani4k commented 4 years ago

works

Can you send your version?

EricwanAR commented 4 years ago

works

Can you send your version?

https://drive.google.com/file/d/14cnj-YdaeQ-W1i9nX3yYQ9nwif30Ed-C/view?usp=drivesdk

I only modified Q related files so this won't work for R

hani4k commented 4 years ago

I'm using Android Q. But what's the difference?

DanGLES3 commented 4 years ago

I'm using Android Q. But what's the difference?

Android R needs a special overlay that needs to target it and be signed using the signature scheme V2, Android R refuses system APKs that aren't signed using that signature scheme, for Android Q the overlays are simply signed using a testkey (since Q does not enforce signature scheme V2) and it's overall easier to work with them

i can easily update the Q overlays on my phone, but the R overlay needs to be worked on Android studio in order to be signed with the new signature scheme

hani4k commented 4 years ago

works

Can you send your version?

https://drive.google.com/file/d/14cnj-YdaeQ-W1i9nX3yYQ9nwif30Ed-C/view?usp=drivesdk

I only modified Q related files so this won't work for R

What's the difference between your mode and the original one? And why? 🙂

EricwanAR commented 4 years ago

works

Can you send your version?

https://drive.google.com/file/d/14cnj-YdaeQ-W1i9nX3yYQ9nwif30Ed-C/view?usp=drivesdk I only modified Q related files so this won't work for R

What's the difference between your mode and the original one? And why?

well, as I said above, I lower the gesture triggering area from 23dp to 18dp, which is less likely to trigger the app switch gesture. I do this because I can't easily drag the elements at the bottom of the screen with the original module setting

DanGLES3 commented 4 years ago

The module is great, but gesture is too sensitive. Every time I move the pushing button at the bottom of the screen (when using Snapseed for example)it would trigger the app switch gesture. I modded the module myself by changing the gesture height from 23dp to 18dp and it works perfect for me. I wonder if you can make the value as default

how's triggering the actual gestures? is it still as reliable? i'm worried that lowering it too much can cause the gestures to become unreliable to trigger

EricwanAR commented 4 years ago

The module is great, but gesture is too sensitive. Every time I move the pushing button at the bottom of the screen (when using Snapseed for example)it would trigger the app switch gesture. I modded the module myself by changing the gesture height from 23dp to 18dp and it works perfect for me. I wonder if you can make the value as default

how's triggering the actual gestures? is it still as reliable? i'm worried that lowering it too much can cause the gestures to become unreliable to trigger

it works quite fine for me anyway, gesture is still reliable. Since I'm using it on a non-full-screen device with higher chinbar , I think somewhere around 20dp might be a better choice for everyone

DanGLES3 commented 4 years ago

The module is great, but gesture is too sensitive. Every time I move the pushing button at the bottom of the screen (when using Snapseed for example)it would trigger the app switch gesture. I modded the module myself by changing the gesture height from 23dp to 18dp and it works perfect for me. I wonder if you can make the value as default

Ok, after some testing it seems 18dp is a good enough value for both fullscreen and non-fullscreen devices, i'll update the module as soon as possible

DanGLES3 commented 4 years ago

the update should already be available, thank you very much for the suggestion

EricwanAR commented 4 years ago

the update should already be available, thank you very much for the suggestion

thank you very much for you work