search

Magisk-Modules-Repo / NfcScreenOff

Read NFC tags when screen is off. Disable NFC tagging sound.
https://forum.xda-developers.com/apps/magisk/module-nfcscreenoff8-t4034903
48 stars 9 forks source link

fix for missing curl and zip #5

Closed DoganM95 closed 4 years ago

DoganM95 commented 4 years ago

@lapwat i just forked your repository and created a (possibly dirty) fix for the "smali folder not found" error.

All i did was adding some lines to customize.sh to copy curl and zip from install.zip to /sbin to be temporarily available until reboot, which allows customize.sh to use these applets for installation.

My quick fix may be dirty and not to follow magisk conventions, so feel free to correct/enhance it. Tested it on my Pixel 3 XL and it worked perfectly, hope this helps.

lapwat commented 4 years ago

Happy it worked for you.

I am not gonna accept this PR unless more people bump into this issue. I don't want to add binaries to the package that few people will use.

I still don't know how it is possible not to have zip or curl while rooted on Android.

Thank you for the job anyway.

lapwat commented 4 years ago

For info if you want to debug your issue:

$ su
:/ # which zip
/system/xbin/zip
:/ # which curl
/system/bin/curl
lapwat commented 4 years ago

Where did you get those binaries?

lapwat commented 4 years ago

I pushed a new version v0.2.1 with zip/curl binaries included.