Magisk-Modules-Repo / Pix3lify

Pix3lify
GNU General Public License v3.0
115 stars 29 forks source link

(PSA) Breaks OxygenOS 10.0.1+ lock screen settings #101

Open m-scha1337 opened 4 years ago

m-scha1337 commented 4 years ago

So i am throwing out the usual bug report form as this is supposed to be only a warning since OxygenOS isn't supported anyways, yet many people use this module with OxygenOS regardless because, traditionally the module did not produce any bugs.

I found this out the hard way after trying to fix this issue for days until i noticed that this module breaks the lock screen settings. It makes it so that the phone always rejects biometric authentication. Additionally, it also prevents the "Screen Lock" list, located under "settings"->"security & lock screen"->"Screen lock" from rendering correctly and completely. Only the option for "none" and "swipe" are shown, however those are non functional either. I was not able to pinpoint the exact cause of the problem.

I think a notice should be put in place in the module description.

19-10-27-03-32-01 00_00_15_11 Still001

thehappydinoa commented 4 years ago

I will leave this open, but this would not be considered a bug as we don't support OOS. Also this appears to be an issue in Android Q stock as well.

thehappydinoa commented 4 years ago

@NateDev100 Dude the lines about OOS warn the user before it installs.

ammmze commented 3 years ago

@thehappydinoa The only thing in install script that mentioned issues with OxygenOS was that the "overlay" is known to cause bootloops and asks if you want to ignore and install overlay anyways, but the other mods still get applied and ultimately breaks things like fingerprints, but I can still boot just fine. Still trying to figure out how to uninstall it without TWRP. The readme indicates we can uninstall via magisk by installing the zip again, but that just runs me through install again 🤷🏻‍♂️

m-scha1337 commented 3 years ago

@ammmze right so.. it has been ages since i first posted this and i don't exactly know how i eventually ended up fixing this. But i think what i ended up having to do was just to reinstall the latest oxygenOS update.. Maybe that fixes it for you?

Let me get that straight though: You are having issues uninstalling the module? Why are you determined to uninstalling it via flashing the module again? Wouldn't uninstalling the module normally via the uninstall button in magisk manager work just fine?

ammmze commented 3 years ago

I got it working by modifying the module to force it to run the uninstall instead of the install, then removed it via magisk manager. I was hesitant to just uninstall via magisk manager because there are other open issues saying uninstall only brought boot loop and the README says:

TO COMPLETELY UNINSTALL THE MODULE AND AVOID BOOTLOOPS, INSTALL THE ZIP AGAIN IN MAGISK OR TWRP!!

But I couldn't flash via twrp because twrp doesn't appear to work for the 7T.

More info on what I did and some suggestions for the maintainers over here.

m-scha1337 commented 3 years ago

Not that it matters now @ammmze but i think there actually is a TWRP version which works on the 7T, it's just not official.

I would like to say that uninstalling it using magisk manager is fine, but i cannot 100% guarantee that that's actually true. I think i removed it that way, but i am not sure anymore since this module is no longer being developed anyways.

But cheers for solving your issue