ammmze
commented
3 years ago Looks like its having trouble getting the existing installed version code. The MOD_VER environment variable points to something like /sbin/.magisk/img/Pix3lify/module.props, which didn't exist on my installation. It is found at /data/adb/modules/Pix3lify/module.props. But I ended up just replacing this block with unity_uninstall and re-packaged the zip and installed that, rebooted, then disabled the module in magisk manager and rebooted again. Now fingerprint is working again!
I'm not sure if the uninstall stuff was just something related to OxygenOS, or if there is an issue with the check in newer versions of magisk. I'll leave this open for now so it can be evaluated.
Also I would recommend updating the install script where it mentions that this is for "non-google devices" to also say something about OxygenOS. I see a check in the environment variables, but the message only says its for non-google devices, which is why I didn't think twice about it and proceeded anyways. Without knowing the code, I wouldn't have known that the message only comes up in particular scenarios. I had figured that since the message didn't appear to apply to my device it was a generic warning, but clearly after digging around more and reading the readme more thoroughly found the OxygenOS compatibility warning.
Also not really something you can control, but on the 7T installing via the new magisk manager is not great. The warning about 'non-google devices' sits behind the little "Flashing" overlay they put on there, so I couldn't actually read the entire warning.
WizerAce
Describe the bug I've installed the module on OnePlus 7T. Fingerprint no longer works. Want to uninstall. Current versions of TWRP for OnePlus 7T are not able to mount system, data, etc. Need to uninstall via Magisk. The readme states:
However, when I try to install the zip again, there is no option to uninstall. Am I missing something?