search

Magisk-Modules-Repo / Pix3lify

Pix3lify
GNU General Public License v3.0
115 stars 29 forks source link

[Flip to Shhh] Support bringup #26

Open imachabeich opened 5 years ago

imachabeich commented 5 years ago

Describe the bug After installing the module, there is no option to enable this feature.

Expected behavior There should be an option to enable 'Flip to Shhh'.

Smartphone (please complete the following information):

TheGabrielHoward commented 5 years ago

It appears for me, but the function isn't enabled

ThatNerdyPikachu commented 5 years ago

Yeah, we still need to enable something, as seen here.

thehappydinoa commented 5 years ago

I believe the issue lies within the mo1654d function

this.f9702f.getPackageManager().getPackageInfo(this.f9715s.mo740a(), 0).getLongVersionCode() < this.f9714r

evaluates to True and throws 

f9697a.mo1036a(Level.WARNING)).mo1048a("com/google/android/apps/wellbeing/autodnd/impl/AutoDndManagerImpl", "setAutoDndEnabled", 294, "AutoDndManagerImpl.java")).mo1050a("Auto DND is not supported and should not be set as enabled.")
ThatNerdyPikachu commented 5 years ago

@imachabeich Btw, where are you checking? (You should be checking in System > Gestures)

imachabeich commented 5 years ago

Yeah, I checked in System > Gestures and System > Digital Wellbeing.

lazerl0rd commented 5 years ago

I have a similar issue too, we're working on it @imachabeich.

AuroraWright commented 5 years ago

https://forum.xda-developers.com/pixel-2-xl/themes/enable-flip-to-shhh-pixel-devices-t3907892 try the apk within my module

thehappydinoa commented 5 years ago

@AuroraWright I will check out adding this now.

lazerl0rd commented 5 years ago

@AuroraWright it's added in here https://github.com/Magisk-Modules-Repo/Pix3lify/pull/76/commits/eb1d06366b04a167907c0d96ab944d561c06a521.

EDIT: After some testing by @Stallix your port still doesn't work. There may be a kernel side/userspace change necessary for Flipp to Shh to function.

AuroraWright commented 5 years ago

Interesting, the apk does enable the feature on my Pixel 2 but I suppose all Pixels might be predisposed for the feature to be unlocked in the future. The only "unique" thing that Flip to Shhh has (that I can tell) is that it uses the proximity sensor.

lazerl0rd commented 5 years ago

@AuroraWright Flip to Shh relies on gyro too IIRC, but also it's possible that it checks for a sysnode of the Pixel's proximity sensors/gyro which are different on other devices.