search

Magisk-Modules-Repo / Pix3lify

Pix3lify
GNU General Public License v3.0
115 stars 28 forks source link

FINISHED (Uploads to Bucket now) #60

Closed JohnFawkes closed 5 years ago

ThatNerdyPikachu commented 5 years ago

hey, great work! will test tomorrow.

  1. how is patch xml defined in install, but still in scope in post fs data?
  2. version code 262 -> 260

(am on mobile can't do a review that well)

JohnFawkes commented 5 years ago

I'm not finished yet and I only did versioncode 262 so it would update on my device when I was flashing to test so I didn't have to flash 2 times

JohnFawkes commented 5 years ago

Please go over code. ive sent a test zip with these changes in it to the TG group. please test to make sure everything is working correctly

JohnFawkes commented 5 years ago

this should be able to be merged today. just a few more things to fix and then tar.xz support on server and we should be good

thehappydinoa commented 5 years ago

Perfect!

thehappydinoa commented 5 years ago

The server is all set

JohnFawkes commented 5 years ago

The server is all set

Awesome! I'm starting to get a migraine so I'm gunna take some Tylenol and lay down for a little bit to get rid of it then ill finish the last couple of bugs and then push. Should I close this PR out then make a brand new one so all the changes are in one commit and easier to follow?

lzlrd commented 5 years ago

@JohnFawkes you can just change the title and description of this merge then squash merge (it's an option in desktop view of this page next to "close pr/comment"). It'll put it under one commit with the title and description of this PR.

thehappydinoa commented 5 years ago

@JohnFawkes you can just change the title and description of this merge then squash merge (it's an option in desktop view of this page next to "close pr/comment").

I think this might be best, but it might be nice to have new reviews and things.

JohnFawkes commented 5 years ago

this is finally all done. unity 3.1, Full logging with tar.xz creation. only thing left is server upload which i havent figured out. in icewizard i just have the user send me the tar.xz directly.

JohnFawkes commented 5 years ago

@stallix there's still a few issues to fix. The curl stuff needs fixed and I think one other issue I can't remember at the moment without looking at it. The core functionality is there though and the tar.xz gets created, it just doesn't upload to our server yet

JohnFawkes commented 5 years ago

Time for 2.6 release