search

Magisk-Modules-Repo / Pix3lify

Pix3lify
GNU General Public License v3.0
115 stars 29 forks source link

Fonts not applying on Samsung devices #80

Closed kaebiene closed 5 years ago

kaebiene commented 5 years ago

Describe the bug On Samsung devices, the font files for lockscreen/header/etc are different from standard Roboto fonts - so the module doesn't have an effect on the fonts across the system (seemingly).

To Reproduce Install the module, reboot.

Expected behavior The fonts change system-wide, especially the clock.

Smartphone (please complete the following information):

Additional context I can provide a list of the fonts required/present in the /system/fonts folder if needed? Otherwise, no worries!

lazerl0rd commented 5 years ago

We need to edit the fonts.xml and also the in-coming update helps out too.

lazerl0rd commented 5 years ago

@kaebiene I just fixed it for many other devices, but can you provide your fonts.xml file from /system/etc?

lazerl0rd commented 5 years ago

Most devices that use Roboto will have the fonts working with this edit -> https://github.com/Magisk-Modules-Repo/Pix3lify/pull/76/commits/eb1d06366b04a167907c0d96ab944d561c06a521.

kaebiene commented 5 years ago

Of course, here's the fonts.xml.

Are you sure about needing to edit SystemUI? At least on Samsung devices, there's ttfs for the clock font, split by android version/year, and replacing those seem to affect the lockscreen. You'll see in the xml, but for 9.0, it's just Clock2019L.ttf. No worries if that would require too much tweaking.

fonts.xml.zip

lazerl0rd commented 5 years ago

Ah, interesting. Well then we could replace those. In AOSP/most other OEMs they need SystemUI edits to change it or force replacing fonts (which isn't recommended).

I may be mixing this up with something else however, but I'll Clock2019L.tff to the files that will be replaced.

lazerl0rd commented 5 years ago

https://github.com/Magisk-Modules-Repo/Pix3lify/pull/76/commits/7b5dee9f56983fa723f691d65e87839136661eb8 fixed here

kaebiene commented 5 years ago

Brilliant! It's a shame it's so complicated on AOSP, but at least there is this small victory.

I'll test it out and report when the new version's been released.

lazerl0rd commented 5 years ago

@kaebiene we tried but Product Sans wasn’t working as Clock for many ppl. I think there was a fix but I’ll need to try remember it.

lazerl0rd commented 5 years ago

Fixed https://github.com/Magisk-Modules-Repo/Pix3lify/commit/083d5815f1f92cfdb8842665b4ce032b299b6bc7. Try latest version @kaebiene.

kaebiene commented 5 years ago

Yup, works now, thanks! All required fonts are replaced.

lazerl0rd commented 5 years ago

:D