search

Magisk-Modules-Repo / energizedprotection

Energized Protection Magisk Module.
https://energized.pro
MIT License
318 stars 54 forks source link

Keep /sdcard clean #21

Open Fingalzzz opened 4 years ago

Fingalzzz commented 4 years ago

Move /sdcard/EnergizedProtection to /sdcard/Documents/EnergizedProtection.

AdroitAdorKhan commented 4 years ago

@AvinashReddy3108 I don't think this would be good idea to put our directory there. Because our directory isn't just a placebo! I'm not sure if users would like to go to /sdcard/Documents/EnergizedProtection/ everytime, for adding some domains or modifying the config file. What do you say about this?

AdroitAdorKhan commented 4 years ago

@Fingalzzz our module isn't the only one which is taking a folder place in your /sdcard, is it? Don't you have any other app/module/recovery taking a folder space there?

Fingalzzz commented 4 years ago

@AdroitAdorKhan No, there's no other folders in my /sdcard except the default ones. Actually, I'm using an app/riru-module to redirect folders in /sdcard to where they should be. There must have some reasons that Android set the folder /sdcard/Documents to be default. IMHO, it's the place to put some backup files or config files. For my own interests, I'd prefer to put EnergizedProtection folder there, since I've got other config files there and it's easier for me to manage. For other users, go to /sdcard/Documents/EnergizedProtection rather than /sdcard/EnergizedProtection just need a single click. I don't think that costs much. What do you say?

DerGoogler commented 1 year ago

/sdcard/Documents is a public directory. Everyone can access it, even apps