search

Magisk-Modules-Repo / sqlite3

sqlite3
21 stars 15 forks source link

Properties missing in your config.sh file #1

Closed xerta555 closed 6 years ago

xerta555 commented 6 years ago

Hello, u miss to set the properties of the binary file in your config.sh file. Also, what's the sqlite version of the binary ? The same as on OP ?

ianmacd commented 6 years ago

There's no need to explicitly set the permissions on the sqlite3 binary, because the default in set_permissions() takes care of it:

set_perm_recursive $MODPATH 0 0 0755 0755

Also, you're proposing mode 777, which is world-writable. That's never a good idea.

The version of the SQLite is 3.24.0, as stated in the README.md.

xerta555 commented 6 years ago

There's no need to explicitly set the permissions on the sqlite3 binary, because the default in set_permissions() takes care of it:

set_perm_recursive $MODPATH 0 0 0755 0755

Effectivly i completly forfet this setting, sorry.

Also, you're proposing mode 777, which is world-writable. That's never a good idea.

Honestly, i didn't be sure of this perm value, a 644 octal value would have been better.

The version of the SQLite is 3.24.0, as stated in the README.md. I have read your README.md file too quickly, sorry for that too.

And thank u very much for this module ! :+1: