Magisk-Modules-Repo / sqlite3

sqlite3
21 stars 15 forks source link

32-bit ARM compatibility, v1.4 candidate #3

Closed moldimolt closed 5 years ago

moldimolt commented 5 years ago
ianmacd commented 5 years ago

I think we're probably better off shipping both a 32 and a 64 bit binary in the module, but installing only one of them, based on the platform.

Could you rework the patch to include the necessary installation logic?

Secondly, why do you feel -Os is preferable to -O2? The stripped 64 bit binary is 820 Kb vs. 1.2 Mb when optimised for size, but I'm not sure users would prefer to trade any execution performance for a file-system saving of 400 Kb. I'm interested to hear your view on this.

Incidentally, when compiling with ndk-build, I had to to use APP_PLATFORM := android-23 to avoid linker errors when I wanted to manipulate LOCAL_CFLAGS. I don't think it's significant, because I'm pretty sure the code will still run on earlier versions, but I mention it, anyway.