search

Magisk-Modules-Repo / submission

Submit your Magisk Modules!
569 stars 88 forks source link

[Submission] TikTok Unlock In China #18

Closed user1121114685 closed 6 years ago

user1121114685 commented 6 years ago

https://github.com/user1121114685/TikTokunlockinChina

ghost commented 6 years ago

@user1121114685 This kind of modules are currently debated and I will have to hold approval for now.

Meanwhile, description in module.prop is still in Chinese, please translate that to English. Also, please re-write README like, first all in English and then all in Chinese, so it's easier for user to read that. Let me know once you have done that.

I will let you know about final decision.

Jaymin Suthar, Repo Moderator.

NOTE: If you don't respond within 48 hours, this submission will be rejected.

ghost commented 6 years ago

@user1121114685 Thanks for waiting, decision has come, and it's nothing related to what modules do.

I saw in your another submission that you didn't even know whether id can contain a space in module.prop. I can't allow such modules since this is a requirement for devs to have basic knowledge of Magisk.

You should not think of it as discouraging, but rather as motivation to learn more about Magisk.

MagiskBot commented 6 years ago

Submission rejected

user1121114685 commented 6 years ago

@sjayminsgithub Who told you I didn't understand. You are obviously bullying the Chinese. Why should I agree?