search

Magisk-Modules-Repo / submission

Submit your Magisk Modules!
568 stars 89 forks source link

[Submission] MIUICamera Port for ZenFone Max Pro M1 #471

Closed gokul1630 closed 5 years ago

gokul1630 commented 5 years ago

https://github.com/gokul1630/MIUICamera-Port-for-Asus-ZenFone-Max-Pro-M1

Jaymin-0-1910 commented 5 years ago

Hi Gokul,

Why are you using absolute path for vendor here ? Are you sure about the working directory when custom_variables is executed ?

Why are using break within if...else construct ? You need to take a crash course on shell scripting.

Check here too. There's a flaw in current abort function provided util_functions.sh, you need to fix that too in your module.

Closing this for now. Once you have been through needy things, open it again !