search

Magisk-Modules-Repo / submission

Submit your Magisk Modules!
569 stars 88 forks source link

[Submission] Custom Bootanimation Installer #647

Closed X1nto closed 4 years ago

X1nto commented 4 years ago

https://github.com/X1nto/Custom-Bootanimation-Installer

Didgeridoohan commented 4 years ago

There are several things that doesn't really make sense with this module.

You (try to) move the bootanimation.zip directly to /system/media, but unless you mount /system rw that should fail. And remember that this is s Magisk module you're working with, it's designed to make systemless modifications (in other words, don't mount /system rw)...

After that you keep working with $MODPATH/system/media/bootanimation.zip though, so maybe the first instance is a mistake? If so, all the backup and restoration stuff you've got going on is completely unnecessary, since Magisk never touches the actual files (unless you add code into your module scripts that does just that).

Lastly, the uninstall script doesn't make any sense either, since $MODPATH, and anything in it will get deleted during uninstall...

I think you need to do some more homework on how Magisk and Magisk Modules actually work before continuing...

X1nto commented 4 years ago

Oh God, thanks for noticing that issues! I somehow pushed uninstall.sh from my first module. About mounting, I made mistakes here and I sincerely apologise, $MODPATH shouldn't be included here in any case as system folder doesn't even exist. What I'm trying to do is to search for bootanimation.zip under /sdcard/ (which should be /storage/emulated/0 as no other options work), then just copy that animation into /system/media folder and it should backup the old animation properly. The detection works perfectly, if the path doesn't exist it just won't proceed, however the issue is that I could not get mv command working, probably because of the limitations. I'm recalling module for now and will re-submit after issues are fixed (if that's even possible with this module). Thanks for replying