Magistu / Epic-Knights

Official repo of Epic Knights mod
https://www.curseforge.com/minecraft/mc-mods/epic-knights-armor-and-weapons
4 stars 8 forks source link

"Barding" causing issues with other "horses" #29

Open fzzyhmstrs opened 4 months ago

fzzyhmstrs commented 4 months ago

Steps to Reproduce

Equip a "Chorse" from Amethyst Imbuement with a "Barding". Game crashes.

Expected Behavior

No crashes.

Actual Behavior

Crashes.

Your Minecraft version

1.20.1 Fabric

Your error log

https://pastebin.com/nfNvdkKH

Additional Comments

Horse Armors by convention have the resource location that ends with "horsearmor[type]". The horse armor "barding" breaks with that convention by having a resoruce location like so: https://github.com/Magistu/Epic-Knights/blob/88be9f811b1cd3702061b9dd681e10fcb3c9f5dc/common/src/main/java/com/magistuarmory/item/ModItems.java#L131. This causes the Chorse renderer to crash.

image

Conclusion