Magistu / Epic-Knights

Official repo of Epic Knights mod
https://www.curseforge.com/minecraft/mc-mods/epic-knights-armor-and-weapons
5 stars 7 forks source link

Recipes can't be filtered or removed using a datapack #31

Closed MrHiTech123 closed 3 months ago

MrHiTech123 commented 5 months ago

Steps to Reproduce

Filtering:

  1. Create a datapack with a pack.mcmeta file such as this one: pack.json (of course, the file extension should be .mcmeta rather than .json, but Github wouldn't let me upload a .mcmeta file). The important parts are the "filter" field and everything inside it.
  2. Put the datapack into the world's datapacks folder
  3. Open the world or execute the /reload command to load the datapack

Manually removing a recipe:

  1. Create a datapack, and in the data/magistuarmory/recipes folder, put an empty file named "bronze_ahlspiess.json" (or name it after any other Epic Knights recipe).
  2. Put the datapack into the world's datapacks folder
  3. Open the world or execute the /reload command to load the datapack

Expected Behavior

All Epic Knights recipes are removed (in the case of filtering), or the specified recipe is removed (in the case of manual removal)

Actual Behavior

No recipes were removed

Your Minecraft version

Minecraft 1.20.1 Forge

Your error log

https://gist.github.com/MrHiTech123/6fc73bc9ad96c23a37db348e87e5d4d8

Additional Comments

I have tested the filtering thing by replacing the namespace with other namespaces, and it removed all the recipes for those namespaces.

I have tested my manually deleted recipes are in the correct folder by changing the name and checking the resultant recipe id. According to everything I've done, the recipe id should be the same, and thus overwrite the Epic Knights recipe.

Conclusion

MrHiTech123 commented 5 months ago

Update: Figured out my issue was Epic Knights moving itself to the bottom of the datapack list somehow, so its recipes always overwrite those of all other mods. Not sure why that happens though.