Magistu / Epic-Knights

Official repo of Epic Knights mod
https://www.curseforge.com/minecraft/mc-mods/epic-knights-armor-and-weapons
4 stars 8 forks source link

Two-Handed weapons don't receive attack/speed penalty when off-hand slot is occupied #8

Closed OverSavior closed 1 year ago

OverSavior commented 1 year ago

Steps to Reproduce

Steps to reproduce:

  1. Create a fresh 1.16.5 profile in Curseforge (tested on both the latest Forge version and 36.2.20 where I remember it still worked)
  2. Only install Epic Knights + dependencies, no other mods
  3. In a new world, try using any weapons with a two-handed tag
  4. Equip a shield/other item in the off-hand slot and repeat step 3
  5. Observe that while there is red text saying the damage and attack speed should've dropped due to off-hand slot being occupied, in reality the damage and attack speed do not change and stay the same

Expected Behavior

Attack/speed reduced when the off-hand slot is occupied

Actual Behavior

Attack/speed doesn't change

Your Minecraft version

1.16.5 Forge

Your error log

https://gist.github.com/OverSavior/98798c0f003acaad54ab52b2a0f9df36

Additional Comments

Edit: Tried manually downloading an older version of the mod (6.3v). On an older version this bug is not present.

Conclusion

Magistu commented 1 year ago

fixed in v8.1