search

MagmaDNN / magmadnn

MagmaDNN: a simple deep learning framework in c++
MIT License
45 stars 7 forks source link

move models directory #39

Closed rfebbo closed 4 years ago

Dando18 commented 4 years ago

@rfebbo This should probably be merged into dev and not master.

rfebbo commented 4 years ago

ok, maybe we can create a hotfix branch or something? The examples aren't compiling using a makefile. I think the models directory was accidentally placed there. It should be in the include directory, right?

Dando18 commented 4 years ago

We can create a v1.2 branch to push hotfixes. That way it doesn't clog up master for future releases. Or you can merge into dev, then we can merge dev into master and mark v1.2.1.

As a future note, we should probably use something from include/models in tests, so this would fail the tests.