MagmaGuy / BetterStructures

Adds structures to Minecraft worlds using WorldEdit!
GNU General Public License v3.0
24 stars 11 forks source link

feat(third-party): Support MMOItems and MythicMobs. #18

Closed CarmJos closed 1 year ago

CarmJos commented 1 year ago

In this fork, i supported:

MagmaGuy commented 1 year ago

Can you provide a sample valid entry for an mmo item and for a mythic mob?

MagmaGuy commented 1 year ago

Also you seem to be protecting the regions that spawn mythic bosses, does the region removal work when killing those mythic bosses?

CarmJos commented 1 year ago

In this fork, you can use mmoitem or mmoitems entry in "treasures" configurations like mmoitems=<TYPE>@<ITEM_ID> .

isEnabled: true
loot:
- mmoitem=SWORD@NICE_ONE:amount=1-1:chance=0.02
- mmoitems=SWORD@SUPERME:amount=1-1:chance=0.02

And if you want to generate MythicMobs in structures, use the sign like

[mythicmobs]
MOB_ID
LEVEL(none for level 1)
CarmJos commented 1 year ago

Well I dont know how does the BETTERSTRUCTURES_PROTECTED flag work, so I just copied the same code just like EliteMobs does.

Do I need to remove the protections?

MagmaGuy commented 1 year ago

Well I dont know how does the BETTERSTRUCTURES_PROTECTED flag work, so I just copied the same code just like EliteMobs does.

Do I need to remove the protections?

The protections for EliteMobs are handled by EliteMobs to where when a boss dies the protection is removed, or else you will end up with tens of thousands of zones where players can't build anything on a server. So yeah. that feature probably shouldn't be there for mythic

CarmJos commented 1 year ago

Fine, i'll remove it.

CarmJos commented 1 year ago

I have Removed unhandled WorldGuard protections.

MagmaGuy commented 1 year ago

Sounds good, I'm just wrapping up some work on EliteMobs but once that is done I will pull this one and pass it to public.

CarmJos commented 1 year ago

My advice is to apply this PR to the main branch as soon as possiable to circumvent possible merge conflicts.Of course, everything depends on your choice.

Looking forward to seeing your updates soon!

MagmaGuy commented 1 year ago

There will be no merge conflicts, I have not modified the codebase from the current public state. I will merge it before starting any of the planned updates for BetterStructures, hopefully within the next couple of days.

CarmJos commented 1 year ago

Any updates?

MagmaGuy commented 1 year ago

Any updates?

Yeah, turns out trying to inject custom mob AI into Minecraft in a way that is compatible with both of the goals system and the brain system is a task that will drive you insane.

Oh you mean for betterstructures?

Your update should be getting merged in the next couple of days, if all goes well.

CarmJos commented 1 year ago

Glad to hear that! I'm looking forward to your updates and wish you all the best.

CarmJos commented 1 year ago

As this pr has not been merged. I have to fix the issues (#19) and pushed here. Please check it ASAP.