search

MagmaGuy / EliteMobs

This is a spigot plugin that aims to extend Minecraft's survival endgame by making mobs more interesting.
http://www.magmaguy.com
GNU General Public License v3.0
154 stars 58 forks source link

Fixed stacked cancel task that create huge lag. #145

Closed broken1arrow closed 1 month ago

broken1arrow commented 3 months ago

I don't know if it a reason you attempt to cancel already stopped task. It seams to create endless stacked tasks that the server try to stop same taskid.

So I simply set it back to null and the problem seams to be gone and not notes negative effects.

With my fix on latest version on GitHub: https://spark.lucko.me/paGLyk157A

Without the fix: https://spark.lucko.me/BVUG0B9Vca it take around 7/8% of a tick.

I also get this problem whit the latest on spigot that says it is still version 8.7.6: https://spark.lucko.me/TlRe4elUuu You see the issue below, did not see this effect on latest version on GitHub with my small fix added yet. explosion

broken1arrow commented 3 months ago

I have not however check your two lib's is updated, you seams to use FreeMinecraftModels 1.1.3-SNAPSHOT I use the local 1.7.4-SNAPSHOT. I can't access the 1.1.3-SNAPSHOT version at all.

MagmaGuy commented 1 month ago

I've implemented a fix for this.