search

MagmaMcFry / Factorissimo2

Factorissimo2, a Factorio mod that adds factory buildings to the game
https://mods.factorio.com/mod/Factorissimo2
MIT License
65 stars 40 forks source link

0.16, I have shooting solution #23

Closed Kremnari closed 6 years ago

Kremnari commented 6 years ago

I have created a stable version of this sidestepping the energy api changes.

Let's get in touch and perhaps it'll help.

Energy API solution, iterate and create multiple consumers/producers (for different flow rates), then swap them out as the user changes the limits.

The graphics were a fairly simple fix. I didn't add Icon_size though..

I only briefly tested these fixes.

Factorissimo2_2.1.9.zip

MagmaMcFry commented 6 years ago

Ah, I wasn't aware the energy API changed. Thanks for the heads-up.

Kremnari commented 6 years ago

Might it be worthwhile to link this fix to the 0.16 discussion so others can at least test it's usability? They can help test and report bugs until you are past your flu.

MagmaMcFry commented 6 years ago

I'm not so happy about that idea. First of all, you didn't add a working patch to update.lua, replacing the old interfaces with your new ones in existing saves, second of all you only "briefly tested these fixes". If you publish that version, then we'll both be up to our asses in complaints like "hey my save won't load", and it will get worse as soon as I add my own update because my update could in turn break saves that contain some of the changes you made.

Also I'd prefer if you gave me your update as a pull request instead of a zip, that way I can see exactly what you changed and add these changes to my own codebase after some 0.15 patches.