search

MagmaMcFry / Factorissimo2

Factorissimo2, a Factorio mod that adds factory buildings to the game
https://mods.factorio.com/mod/Factorissimo2
MIT License
65 stars 40 forks source link

Fix factoriomaps API name mismatch #48

Closed sonowz closed 5 years ago

sonowz commented 5 years ago

My factorissimo-factoriomap compatibility is broken due to API name mismatch. I've done something wrong with other mods, or this commit will fix the issue.

sonowz commented 5 years ago

See factoriomaps code here:

https://github.com/L0laapk3/FactorioMaps/blob/06efafbc9aafdb2031fdc97c1855924f0978cf5f/api.lua#L130-L133

L0laapk3 commented 5 years ago

Hey there! I'm the developer of factoriomaps, I havent been able to publish factoriomaps with API yet. This means that factorissimo is trying to call API objects that don't exist yet. Sorry about that!

You can either wait for release 3.5.0, or try the dev branch.

L0laapk3 commented 5 years ago

Upon further inspectation, Ive found that the API that made it into release 3.4.0 is accidental, its a dummy API that does nothing and shouldn't have been in there at all. Again, apologies!

sonowz commented 5 years ago

With current mod versions, factoriomaps auto.py crashes when factorissimo is enabled. This commit fixes crash. crash

L0laapk3 commented 5 years ago

The name factorissimo uses is correct. Factoriomaps 3.4.0 was accidentally released with a mockup version of the API that does nothing. It wasn't supposed to be there at all, then there would be a different error of trying to call an API that doesn't exist at all. I was supposed to release factoriomaps 3.5.0 at the same time as factorissimo, but I had some last minute hold ups. Sorry about this, I'm working on it!

sonowz commented 5 years ago

OK, then I will close this :)

L0laapk3 commented 5 years ago

Just letting you know that I finally managed to get that multi hour session in to track down those last stubborn bugs and roll out FactorioMaps 3.5.0 :)