MagmaMcFry / Factorissimo2

Factorissimo2, a Factorio mod that adds factory buildings to the game
https://mods.factorio.com/mod/Factorissimo2
MIT License
65 stars 40 forks source link

Crash in 'is_inside_connected' when called in fluid.lua #49

Open andreyskv opened 5 years ago

andreyskv commented 5 years ago

The crash happens sometimes if you try to place a connecting pipe at the connection point. It might be hard to reproduce since not all buildings seem to be affected. I noticed what helps is removing the building and placing it back. After that no crashes.

The crash happened a few times and only in 0.17. The save came from 0.16. The error is pointing to 'is_inside_connected' fluid.lua. It seems like index out of range or something like that. I will post a stacktrace if happens again.

andreyskv commented 5 years ago

27520.238 Error MainLoop.cpp:1223: Exception at tick 130884765: The mod Factorissimo2 caused a non-recoverable error. Please report this error to the mod author.

Error while running event Factorissimo2::on_tick (ID 0) LuaEntity API call when LuaEntity was invalid. stack traceback: Factorissimo2/connections/fluid.lua:35: in function 'is_outside_connected' Factorissimo2/connections/fluid.lua:54: in function '?' Factorissimo2/connections.lua:170: in function 'recheck_factory' Factorissimo2/connections.lua:208: in function 'update' Factorissimo2/control.lua:1158: in function <Factorissimo2/control.lua:1131> stack traceback: [C]: in function 'index' Factorissimo2/connections/fluid.lua:35: in function 'is_outside_connected' Factorissimo2/connections/fluid.lua:54: in function '?' Factorissimo2__/connections.lua:170: in function 'recheck_factory' Factorissimo2/connections.lua:208: in function 'update' Factorissimo2/control.lua:1158: in function <Factorissimo2/control.lua:1131