search

MagneticParticleImaging / MDF

Magnetic Particle Imaging Data Format
Other
18 stars 10 forks source link

Fix errors in Julia example #104

Closed jonschumacher closed 3 years ago

jonschumacher commented 3 years ago

The current Julia example has errors due to two deprecations:

  1. Pkg.installed() has been depracated. Fixed in this PR by using Pkg.dependencies() as proposed in https://discourse.julialang.org/t/how-to-use-pkg-dependencies-instead-of-pkg-installed/36416.
  2. HDF5.hdf5_to_julia_eltype has been removed. The fix was copied over from https://github.com/MagneticParticleImaging/MPIFiles.jl/blob/27fa4fe46e9b9b035edb85b155b346b182584aad/src/Utils.jl#L30.
tknopp commented 3 years ago

I merge this as is. In the long run we would need test for this.