search

MagneticParticleImaging / OpenMPIData.jl

Open MPI Data Initiative
Other
10 stars 5 forks source link

Not working with Julia 1.8 #8

Open jonschumacher opened 1 year ago

jonschumacher commented 1 year ago

After years of not trying the data in this repo, I tried to run the examples with Julia 1.8 and the latest MPIReco as well as MPIReco down to 0.3.3, which seems to be the lowest version for Julia 1.8. The images look inverted. Do you have an idea what changes in MPIReco oder MPIFiles might cause these problems? Here is a picture of the reco1D.jl output: grafik

tknopp commented 1 year ago

I think we put a transfer function into the MDFs without using it at the time we created the repository. The default was later changed to always use the transfer function if it is available and probably that is the reason.

tknopp commented 1 year ago

try setting tfCorrection = false as a reconstruction parameter.

jonschumacher commented 1 year ago

I first tried to pass down the tf correction flag in https://github.com/MagneticParticleImaging/MPIReco.jl/pull/19 but this did not change the output. rxHasTransferFunction(file) is false for both SM and measurement and thus the tfCorrection switch should already be false. The adapted scripts are in https://github.com/MagneticParticleImaging/OpenMPIData.jl/pull/9. Seems like this is not the issue. Do you have another idea what is going wrong?