search

MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

WIP: Implement partial reading for ISMRMRD files #100

Closed tknopp closed 1 year ago

tknopp commented 1 year ago

This is a first attempt to implement partial reading from ISMRMRD files (closes #76). What is still missing is the fix of the header. I do not yet have an idea how to do that. We probably want to allow just UnitRanges for the applied slice argument.

@mrikasper @alexjaffray: I don't have data with multiple slices / repetitions at hand. Would be great if you could give this a test + help me fixing the header. The test should include timing. I expect that the sliced reading should be faster and acquire only the memory required for the slice. But I am only 90% sure about that.

codecov-commenter commented 1 year ago

Codecov Report

Base: 64.23% // Head: 64.23% // No change to project coverage :thumbsup:

Coverage data is based on head (011bd8a) compared to base (dcf7799). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #100 +/- ## ======================================= Coverage 64.23% 64.23% ======================================= Files 37 37 Lines 1675 1675 ======================================= Hits 1076 1076 Misses 599 599 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

alexjaffray commented 1 year ago

Thanks for looping me in @tknopp. @mrikasper and I have spiral data available at https://zenodo.org/record/6510021#.Yxe_7y0r1QI and are just thinking about how to package it into a small, test-friendly example. I'l take a look at this branch and see what we need to do to make it work with our dataset.

tknopp commented 1 year ago

For the unit tests we could alternatively simulate some ISMRMRD files with our internal simulation framework. This would be more flexible.

tknopp commented 1 year ago

committed directly in https://github.com/MagneticResonanceImaging/MRIReco.jl/commit/2e29cb913061d53aa477b63203086fb7556c6573 since this had conflicts.