MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

KooshballTrajectory does not work for Float32 #106

Closed aTrotier closed 1 year ago

aTrotier commented 1 year ago
tr = MRIReco.KooshballTrajectory(Float32,10000, 128)

returns the error :

 ERROR: MethodError: no method matching Trajectory(::String, ::Matrix{Float32}, ::Vector{Float32}, ::Float64, ::Float64, ::Int64, ::Int64, ::Int64, ::Bool, ::Bool)
Closest candidates are:
  Trajectory(::String, ::Matrix{T}, ::Vector{T}, ::T, ::T, ::Int64, ::Int64, ::Int64, ::Bool, ::Bool) where T at ~/.julia/dev/MRIReco/MRIBase/src/Trajectories/Trajectories.jl:25
  Trajectory(::AbstractMatrix{T}, ::Int64, ::Any; times, TE, AQ, numSlices, cartesian, circular) where T<:AbstractFloat at ~/.julia/dev/MRIReco/MRIBase/src/Trajectories/Trajectories.jl:37
Stacktrace:
 [1] KooshballTrajectory(::Type{Float32}, numProfiles::Int64, numSamplingPerProfile::Int64; TE::Float64, AQ::Float64, kargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ MRIBase ~/.julia/dev/MRIReco/MRIBase/src/Trajectories/3D/Kooshball.jl:23
 [2] KooshballTrajectory(::Type{Float32}, numProfiles::Int64, numSamplingPerProfile::Int64)
   @ MRIBase ~/.julia/dev/MRIReco/MRIBase/src/Trajectories/3D/Kooshball.jl:17
 [3] top-level scope
   @ ~/Documents/GitHub/Undersampling_T2map/_research/sample_image.jl:5

It works with

tr = MRIReco.KooshballTrajectory(Float32,10000, N)
migrosser commented 1 year ago

this should be fixed by d1efe5d .