MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

sdc on NFFTOp failed due to p.params.precompute = TENSOR #107

Closed aTrotier closed 1 year ago

aTrotier commented 1 year ago

Code to reproduce error :

N=128
NPro = 10000
tr = MRIReco.KooshballTrajectory(Float64,NPro, N)
nufftOp =  NFFTOp((N,N,N), tr; toeplitz=false, oversamplingFactor=2, kernelSize=2)
dcf = sdc(nufftOp.plan; iters=10)

I get :


ERROR: MethodError: no method matching isless(::Array{Float64, 3}, ::Array{Float64, 3})
Closest candidates are:
  isless(::Any, ::Missing) at missing.jl:88
  isless(::Missing, ::Any) at missing.jl:87
Stacktrace:
  [1] max(x::Array{Float64, 3}, y::Array{Float64, 3})
    @ Base ./operators.jl:480
  [2] _fast(#unused#::typeof(max), x::Array{Float64, 3}, y::Array{Float64, 3})
    @ Base ./reduce.jl:609
  [3] mapreduce_impl(f::typeof(identity), op::typeof(max), A::Array{Array{Float64, 3}, 3}, first::Int64, last::Int64)
    @ Base ./reduce.jl:638
  [4] _mapreduce
    @ ./reduce.jl:434 [inlined]
  [5] _mapreduce_dim
    @ ./reducedim.jl:365 [inlined]
  [6] #mapreduce#764
    @ ./reducedim.jl:357 [inlined]
  [7] mapreduce
    @ ./reducedim.jl:357 [inlined]
  [8] #_maximum#782
    @ ./reducedim.jl:999 [inlined]
  [9] _maximum
    @ ./reducedim.jl:999 [inlined]
 [10] #_maximum#781
    @ ./reducedim.jl:998 [inlined]
 [11] _maximum
    @ ./reducedim.jl:998 [inlined]
 [12] #maximum#779
    @ ./reducedim.jl:994 [inlined]
 [13] maximum
    @ ./reducedim.jl:994 [inlined]
 [14] sdc(p::NFFT.NFFTPlan{Float64, 3, 1}; iters::Int64)
    @ NFFTTools ~/.julia/packages/NFFTTools/D76NU/src/samplingDensity.jl:14
 [15] top-level scope
    @ ~/Documents/GitHub/Undersampling_T2map/_research/sample_image.jl:11

but it works with :

plan = MRIReco.plan_nfft(tr.nodes, (N,N,N), m=2, σ=2)
dcf = sdc(plan; iters=10)

because the option is POLYNOMIAL::PrecomputeFlags in this case.

tknopp commented 1 year ago

fixed by https://github.com/JuliaMath/NFFT.jl/commit/10a3751985abe51fa0590ef430311f663a9f4c09