Closed aTrotier closed 1 year ago
cool thanks, I will have a look later or tomorrow.
@time img = fftshift( reconstruction(acqData2d, params).data[:,:,:,1,1], 2)
Why do we have to use the fftshift ? It is just because the offset along that dimension is not corrected ? If yes maybe we can use that as a test to implement the offset correction from ismrmrd files
Why do we have to use the fftshift ?
I don't know, I just translated 1to1 the FFTOp
how it was used before. I don't want MRIBase
to depend on MRIOperators
. Therefore this small workaround. We already have the indirect dependency on FFTW
because of NFFTTools
.
I was talking about the fftshift after reconstruction not the one to replace the fftop.
I'll keep that in mind for later
Why do we have to use the fftshift ? It is just because the offset along that dimension is not corrected ? If yes maybe we can use that as a test to implement the offset correction from ismrmrd files
Ah sorry, I misinterpreted that. Yes, I guess that the fftshift
is just because of the offset
not being taken into account. So this seems to be a workaround we should fix. Will still still merge now, since we can do this in follow up work. And yes, this file would be a nice unit test.
Base: 63.05% // Head: 63.05% // No change to project coverage :thumbsup:
Coverage data is based on head (
73263ea
) compared to base (6545070
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
2 remarks :
Pkg.add(Pkg.PackageSpec(name="Wavelets",rev="master"))