MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

update Mridataexample #130

Closed aTrotier closed 1 year ago

aTrotier commented 1 year ago

2 remarks :

tknopp commented 1 year ago

cool thanks, I will have a look later or tomorrow.

aTrotier commented 1 year ago
@time img = fftshift( reconstruction(acqData2d, params).data[:,:,:,1,1], 2)

Why do we have to use the fftshift ? It is just because the offset along that dimension is not corrected ? If yes maybe we can use that as a test to implement the offset correction from ismrmrd files

tknopp commented 1 year ago

Why do we have to use the fftshift ?

I don't know, I just translated 1to1 the FFTOp how it was used before. I don't want MRIBase to depend on MRIOperators. Therefore this small workaround. We already have the indirect dependency on FFTW because of NFFTTools.

aTrotier commented 1 year ago

I was talking about the fftshift after reconstruction not the one to replace the fftop.

I'll keep that in mind for later

tknopp commented 1 year ago

Why do we have to use the fftshift ? It is just because the offset along that dimension is not corrected ? If yes maybe we can use that as a test to implement the offset correction from ismrmrd files

Ah sorry, I misinterpreted that. Yes, I guess that the fftshift is just because of the offset not being taken into account. So this seems to be a workaround we should fix. Will still still merge now, since we can do this in follow up work. And yes, this file would be a nice unit test.

codecov-commenter commented 1 year ago

Codecov Report

Base: 63.05% // Head: 63.05% // No change to project coverage :thumbsup:

Coverage data is based on head (73263ea) compared to base (6545070). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ======================================= Coverage 63.05% 63.05% ======================================= Files 8 8 Lines 249 249 ======================================= Hits 157 157 Misses 92 92 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.