search

MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

Add noise uncorrelation (data pre-whitening) before the reconstruction #140

Closed Laura2305 closed 1 year ago

Laura2305 commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Base: 63.05% // Head: 65.67% // Increases project coverage by +2.61% :tada:

Coverage data is based on head (1967d5d) compared to base (a616737). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #140 +/- ## ========================================== + Coverage 63.05% 65.67% +2.61% ========================================== Files 8 9 +1 Lines 249 268 +19 ========================================== + Hits 157 176 +19 Misses 92 92 ``` | [Impacted Files](https://codecov.io/gh/MagneticResonanceImaging/MRIReco.jl/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging) | Coverage Δ | | |---|---|---| | [src/Reconstruction/IterativeReconstruction.jl](https://codecov.io/gh/MagneticResonanceImaging/MRIReco.jl/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging#diff-c3JjL1JlY29uc3RydWN0aW9uL0l0ZXJhdGl2ZVJlY29uc3RydWN0aW9uLmps) | `48.59% <100.00%> (+1.48%)` | :arrow_up: | | [src/Reconstruction/RecoParameters.jl](https://codecov.io/gh/MagneticResonanceImaging/MRIReco.jl/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging#diff-c3JjL1JlY29uc3RydWN0aW9uL1JlY29QYXJhbWV0ZXJzLmps) | `82.45% <100.00%> (+1.68%)` | :arrow_up: | | [src/Reconstruction/Reconstruction.jl](https://codecov.io/gh/MagneticResonanceImaging/MRIReco.jl/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging#diff-c3JjL1JlY29uc3RydWN0aW9uL1JlY29uc3RydWN0aW9uLmps) | `53.84% <100.00%> (ø)` | | | [src/Tools/NoiseDeCorr.jl](https://codecov.io/gh/MagneticResonanceImaging/MRIReco.jl/pull/140?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging#diff-c3JjL1Rvb2xzL05vaXNlRGVDb3JyLmps) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tknopp commented 1 year ago

This PR looks very good, thank you @Laura2305. I would merge this if there are no objections.

Laura2305 commented 1 year ago

You're welcome. I'll have time to implement the raw data pre-whitening for the multi-coil, multi-echo reconstruction next week. I can open a new PR for that, or we can keep this one open for a few more days, as you prefer.

tknopp commented 1 year ago

Let's merge this. The multi-echo case can be implemented later. I gave you access rights so that you can also work on branches within this repository. This is often easier than to use a fork.