search

MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

Noise decorrelation implementation for multiCoilMultiEcho reconstruction #141

Closed Laura2305 closed 1 year ago

Laura2305 commented 1 year ago

Following discussion #135 and pull request #140 I have implemented the noise decorrelation in the multiCoilMultiEcho reconstruction. However, as far as I can tell there are no tests implemented for this reconstruction and when I try to run it on my data I get an error, so I was not able to test it. It seems like the function multiCoilMultiEchoData in the file AcqData.jl should be exported to make the reconstruction work. I assume there is a reason why this function was not exported, so I am not sure how to proceed. I also have very little time to dedicate to this in the near future, so it would be great if someone else could write a test for this function.

alexjaffray commented 1 year ago

Looks good to me @Laura2305, the style is the same as your contribution to the multiCoil reco codebase which was already merged, and everything passes CI. Safe to merge @tknopp ?

tknopp commented 1 year ago

I am merging this but what we really need is tests for the multi-echo reconstruction.