search

MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

Fix sensitivity op #145

Closed JakobAsslaender closed 1 year ago

JakobAsslaender commented 1 year ago

Hi, I mostly generalized the input to abstract types as some operators in this package return type subArray and hence do not work well with this operator.

Meanwhile.... I also fixed a bug for a missing storage_type function for DiagOp and I also capitalized all constructors of the latter type. The latter is a breaking change, but I found it kinda confusing (and was confused by it) that the main constructor and the convenience constructors had different capitalizations.

Sorry for putting multiple things in on PR -- that was me being lazy.

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2856ec3) 65.67% compared to head (c80532f) 65.67%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #145 +/- ## ======================================= Coverage 65.67% 65.67% ======================================= Files 9 9 Lines 268 268 ======================================= Hits 176 176 Misses 92 92 ``` | [Impacted Files](https://codecov.io/gh/MagneticResonanceImaging/MRIReco.jl/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging) | Coverage Δ | | |---|---|---| | [src/Reconstruction/IterativeReconstruction.jl](https://codecov.io/gh/MagneticResonanceImaging/MRIReco.jl/pull/145?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging#diff-c3JjL1JlY29uc3RydWN0aW9uL0l0ZXJhdGl2ZVJlY29uc3RydWN0aW9uLmps) | `48.59% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MagneticResonanceImaging)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

tknopp commented 1 year ago

Ok, looks fine, just some small comments after which we can merge.

JakobAsslaender commented 1 year ago

Fixed the capitalization as suggested.