search

MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

Implement tests for multiEcho reconstruction #154

Closed tknopp closed 10 months ago

tknopp commented 1 year ago

As found out in #141 we right now have no tests for the multi-echo reconstruction methods. I had a quick look add code coverage and it seems to be uncovered. Ping: @migrosser: Did you have a simple test somewhere laying around?

aTrotier commented 1 year ago

I have one test for multiCoilMultiEcho in the subspace branch : https://github.com/MagneticResonanceImaging/MRIReco.jl/blob/36d32de3e9117d784d1a9a863e4fb06264eb3684/test/testReconstruction.jl#L439

I can also reconstruct with "multiEcho" case and coil combined them or use mergeChannels

tknopp commented 1 year ago

great. Probably it would be better to first commit the tests only. If I get it right, the branch is still work in progress?

aTrotier commented 1 year ago

Actually it "works", I have to build an example in the documentation but I thought plots in literate example were not showing up... But it seems it works now. Can you confirm that on your side ? https://magneticresonanceimaging.github.io/MRIReco.jl/latest/generated/examples/01-binning/

If it works, I will add a literate example for subspace and then we can merge after review ?

aTrotier commented 1 year ago

@tknopp do you want more advanced test : https://github.com/MagneticResonanceImaging/MRIReco.jl/pull/148/commits/0050644efcdc372c53371ddba3579cb4864bcc45