MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

Fix espirit for odd matrix sizes #156

Closed SebastianFlassbeck closed 11 months ago

SebastianFlassbeck commented 11 months ago

ESPIRIT did not work for odd matrix sizes. The bug was essentially a missing ifftshift, which we implemented in a non-allocating way.

JakobAsslaender commented 11 months ago

@tknopp: Can you review this PR? The failing tests are not related to this PR but to the mess, I created in the master branch. No idea how to re-run them with the latest master branch commits. Many thanks!

codecov-commenter commented 11 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (fdc524c) 65.56% compared to head (f394bf1) 65.56%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #156 +/- ## ======================================= Coverage 65.56% 65.56% ======================================= Files 9 9 Lines 273 273 ======================================= Hits 179 179 Misses 94 94 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.