MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

MRIFiles.jl: Additional `<userParameters>` tag is included within XML header of exported MRD #166

Closed cncastillo closed 7 months ago

cncastillo commented 7 months ago

Fixes:

More information can be found on https://github.com/cncastillo/KomaMRI.jl/issues/214, but basically the additional tag crashes Python's MRD reader.

I preserved the current behaviour for paramName != "userParameters".

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (27bd616) 86.68% compared to head (4f780cd) 86.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #166 +/- ## ======================================= Coverage 86.68% 86.68% ======================================= Files 10 10 Lines 368 368 ======================================= Hits 319 319 Misses 49 49 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tknopp commented 7 months ago

Thanks