MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

add NFFTNormalOp util functions #44

Closed JakobAsslaender closed 2 years ago

JakobAsslaender commented 2 years ago

Hi, I just added a few utility functions for the NFFTNormalOp and removed the requirement that tr is of type Trajectory, which makes it harder to use of the nodes key argument and has, to the best of my knowledge, no real benefit.

codecov-commenter commented 2 years ago

Codecov Report

Merging #44 (7b7af47) into master (aa3603b) will decrease coverage by 0.14%. The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   63.77%   63.63%   -0.15%     
==========================================
  Files          63       63              
  Lines        3034     3041       +7     
==========================================
  Hits         1935     1935              
- Misses       1099     1106       +7     
Impacted Files Coverage Δ
src/Operators/NFFTOp.jl 32.81% <12.50%> (-4.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa3603b...7b7af47. Read the comment docs.

tknopp commented 2 years ago

Would it be possible using your new toeplitz code here, which would give us ND for free?

JakobAsslaender commented 2 years ago

Yeah, we should do so and remove the Toeplitz implementation here to avoid two sets of conflicting code. I'll open an issue for us to remember.