search

MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

Toeplitz >nfft.jl #50

Closed JakobAsslaender closed 2 years ago

JakobAsslaender commented 2 years ago

Closes #45

codecov-commenter commented 2 years ago

Codecov Report

Merging #50 (a2f2a4a) into master (b9b8475) will increase coverage by 0.89%. The diff coverage is 79.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   63.60%   64.50%   +0.89%     
==========================================
  Files          63       63              
  Lines        3039     3048       +9     
==========================================
+ Hits         1933     1966      +33     
+ Misses       1106     1082      -24
Impacted Files Coverage Δ
src/Operators/NFFTOp.jl 84.90% <79.48%> (+52.09%) :arrow_up:
src/IO/HDF5Types.jl 86.77% <0.00%> (-8.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9b8475...a2f2a4a. Read the comment docs.

tknopp commented 2 years ago

well done, many thanks.

Merging this now but one minor thing: The name Toeplitz_NormalOp is too generic IMHO. After all its still a special structure linked to the NFFT. NFFTNormalOp missed the fact that it exploited the toeplitz trick. I thus suggest NFFTToeplitzNormalOp (we use camel case for types).

JakobAsslaender commented 2 years ago

Sure, we can do that.