search

MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

Bruker to acquisitionData : ComplexF32 -> ComplexF64 #61

Closed aTrotier closed 2 years ago

aTrotier commented 2 years ago

Hi, For now data are converted to ComplexF64 at this line I can use Maybe dtype = Complex{acqDataType(b)} at this step.

However during the conversion from raw to acq data are converted to ComplexF64. Is that an issue to keep the type in the acquisitionData ? I thought it was to be coherent with the MRD format but it appears it is also de F32

Can we keep the type all the way from conversion to reconstruction ?

tknopp commented 2 years ago

I am not sure anymore why I did this. But we certainly want to support Float32. So dtype = Complex{acqDataType(b)} seems like a good idea. You might find this in other places as well.

tknopp commented 2 years ago

Actually we have https://github.com/MagneticResonanceImaging/MRIReco.jl/blob/2978ca778d5a6c2ccef06d7988eec966ccfeb63a/src/Datatypes/RawAcqData.jl#L55 So the Profile cannot hold ComplexF64. Not sure where you are seeing that.

aTrotier commented 2 years ago

During the conversion to acq : https://github.com/MagneticResonanceImaging/MRIReco.jl/blob/2978ca778d5a6c2ccef06d7988eec966ccfeb63a/src/Datatypes/AcqData.jl#L22

tknopp commented 2 years ago

That is a different type, I thought the RawDataAcquisition type was the issue. AcquisitionData could/should indeed be parametric in T.

tknopp commented 2 years ago

I think this issue is solved. If not, please reopen.