Change Function Scope and dims() -> ndims()

MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction

https://magneticresonanceimaging.github.io/MRIReco.jl/latest/

Other

85 stars 22 forks source link

Change Function Scope and dims() -> ndims() #80

Closed alexjaffray closed 2 years ago

alexjaffray commented 2 years ago

It seems some function definitions were isolated in scope from where they were being called due to the package split. These were the ones I found in my testing, and I have put them where it seems to make sense (or at least don't error). I'm not sure about keeping the export statements for the functions yet but probably we should for flexibility.

Please review and let me know if this is a reasonable solution.

alexjaffray commented 2 years ago

Seems there's also a compat issue with LinearOperators introduced in v2.3.0 or v2.3.1. I have forced the versioning to address the issue for now but the compatibility issue occurs on the main branch as well. Perhaps we should change the CI runs to nightly so that we can catch these kinds of things as they pop up?

alexjaffray commented 2 years ago

Figured out versioning, sorry for the confusion. PR is ready for review @tknopp

tknopp commented 2 years ago

Looks good, thanks!