MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction
https://magneticresonanceimaging.github.io/MRIReco.jl/latest/
Other
85 stars 22 forks source link

Multiple improvements for BrukerFile #88

Closed aTrotier closed 2 years ago

aTrotier commented 2 years ago

- Read all visu params, not only the specific subset.
- recoData read all the "frames" and works for any output types.

Related to #87 and #86

---
NOTES :
1) Bruker store the data like that :
`x,y,z,channel,frame`
where frame is anything -> echo/slice (for complex data the 1st half of data are real and second one imaginary)
For now, the output of recoData is not reordered but because we can also have some post-process data in procno, I think it is more robust like that.
2) I have data with multiple reconstruction of 2D_FLASH :
- 32Float + Magnitude
- 32 Float + Real
- 32 Int + Complex Shuffle
- UInt8 + Magn

@tknopp If you want I can create a test and send you the data
tknopp commented 2 years ago

great! Yes please send me the data and I add it to the test datasets.

tknopp commented 2 years ago

Added the new dataset to master: https://github.com/MagneticResonanceImaging/MRIReco.jl/blob/master/test/Artifacts.toml Locally master tests pass for me.

aTrotier commented 2 years ago

I'll just put the test in place and then we will be good to go on my side. For now, the PR is just the stuff I need in order to 1) work with custom sequence + custom parameters. 2) Read the 2dseq file.

Later I might work on a way to create a complete working procno folder from scratch (for now I'm just editing the pars_visu according to my new 2dseq)

Le ven. 24 juin 2022 à 16:25, Tobias Knopp @.***> a écrit :

Added the new dataset to master: https://github.com/MagneticResonanceImaging/MRIReco.jl/blob/master/test/Artifacts.toml Locally master tests pass for me.

— Reply to this email directly, view it on GitHub https://github.com/MagneticResonanceImaging/MRIReco.jl/pull/88#issuecomment-1165628479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC5P7O5NC75V2GJFC53QHGLVQXANTANCNFSM5ZXPM5FA . You are receiving this because you authored the thread.Message ID: @.***>

--

TROTIER Aurélien 31 allée de la Biotte 33470 Gujan-Mestras 06.09.12.61.61 @.***

aTrotier commented 2 years ago

Seems good on my side :)

tknopp commented 2 years ago

tests pass locally for me.