MagneticResonanceImaging / MRIReco.jl

Julia Package for MRI Reconstruction

https://magneticresonanceimaging.github.io/MRIReco.jl/latest/

Other

85 stars 22 forks source link

Read Bruker method file only the first time #96

Closed aTrotier closed 2 years ago

aTrotier commented 2 years ago

PR corresponding to issue #94

method file is only read one time.
A test has been added : read a parameters should take less than < 0.0001 s

Results on my mac

┌ Info: Read parameters timing │ t1 = 0.380862047 └ t2 = 1.51e-6

tknopp commented 2 years ago

Ah, was the issue that the parameter file was parsed several times?

aTrotier commented 2 years ago

Ah, was the issue that the parameter file was parsed several times?

yes, b.methodRead was set totrue but not taken into account by the else + condition line. It is weird else + condition does not throw an error.

tknopp commented 2 years ago

Ok, thanks! Will merge. CI problems are because of NFFT.

aTrotier commented 2 years ago

Yes I know. If you merge #95. I think it will work again no ?

edit : you merged it before my comment :D

tknopp commented 2 years ago

There is still a version conflict but that might be because of CI not using the master of all sub packages. So we might need some version on the subpackage.